[coreboot-gerrit] Change in coreboot[master]: sb/intel/i82801ix: Don't select HAVE_INTEL_FIRMWARE on Q35-QEMU

Arthur Heymans (Code Review) gerrit at coreboot.org
Thu Jan 4 14:47:14 CET 2018


Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/23090


Change subject: sb/intel/i82801ix: Don't select HAVE_INTEL_FIRMWARE on Q35-QEMU
......................................................................

sb/intel/i82801ix: Don't select HAVE_INTEL_FIRMWARE on Q35-QEMU

The Qemu q35 target doesn't support or needs Intel Firmware blobs so
it doesn't make sense to select that option on this hardware.

The result of this change will be that when changing the ROM chip
size, CBFS_SIZE will automatically fill the whole flash which is
desirable in this case.

Change-Id: I89b0c2a7b3e9c163ce4b4eb5b38ab5fa70ba3cfa
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/southbridge/intel/i82801ix/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/23090/1

diff --git a/src/southbridge/intel/i82801ix/Kconfig b/src/southbridge/intel/i82801ix/Kconfig
index 6879bce..fcf2eb5 100644
--- a/src/southbridge/intel/i82801ix/Kconfig
+++ b/src/southbridge/intel/i82801ix/Kconfig
@@ -25,7 +25,7 @@
 	select HAVE_SMI_HANDLER
 	select HAVE_USBDEBUG_OPTIONS
 	select SOUTHBRIDGE_INTEL_COMMON_GPIO
-	select HAVE_INTEL_FIRMWARE
+	select HAVE_INTEL_FIRMWARE if !BOARD_EMULATION_QEMU_X86_Q35
 
 if SOUTHBRIDGE_INTEL_I82801IX
 

-- 
To view, visit https://review.coreboot.org/23090
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I89b0c2a7b3e9c163ce4b4eb5b38ab5fa70ba3cfa
Gerrit-Change-Number: 23090
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180104/79dbfce8/attachment-0001.html>


More information about the coreboot-gerrit mailing list