[coreboot-gerrit] Change in coreboot[master]: nb/intel/sandybridge: Reduce storage size

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/23088 )

Change subject: nb/intel/sandybridge: Reduce storage size
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/#/c/23088/1/src/northbridge/intel/sandybridge/raminit_common.c
File src/northbridge/intel/sandybridge/raminit_common.c:

https://review.coreboot.org/#/c/23088/1/src/northbridge/intel/sandybridge/raminit_common.c@2106
PS1, Line 2106: 			    MIN(MAX(timC, 0), MAX_TIMC);
I haven't check what exactly this function is supposed to do but wouldn't you want a warning on overflows?



-- 
To view, visit https://review.coreboot.org/23088
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3bb026fb1bd81b66f8a5be333760990d924071f
Gerrit-Change-Number: 23088
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 04 Jan 2018 11:50:42 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180104/cf34d396/attachment.html>