[coreboot-gerrit] Change in coreboot[master]: util/broadcom/secimage: Add OpenSSL 1.1 support

Alex Thiessen (Code Review) gerrit at coreboot.org
Thu Jan 4 03:26:55 CET 2018


Hello build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/23069

to look at the new patch set (#5).

Change subject: util/broadcom/secimage: Add OpenSSL 1.1 support
......................................................................

util/broadcom/secimage: Add OpenSSL 1.1 support

The `secimage` utility uses OpenSSL to calculate HMAC, which it does in
a rather unorthodox way, using deprecated `HMAC_CTX_init` API and
repeated calling of `HMAC_Init_ex` without a clear reason. The former
causes build errors with OpenSSL 1.1 while the rest of the
`HmacSha256Hash` function is confusing and overly complex.

Make `HmacSha256Hash` use a single OpenSSL API call. Test passed:
resulting signed binary remains identical.

Change-Id: Ib23c0ad96f9d8cc30ad357de8c0b0ba967c7d724
Signed-off-by: Alex Thiessen <alex.thiessen.de+coreboot at gmail.com>
---
M util/broadcom/secimage/crypto.c
1 file changed, 8 insertions(+), 11 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/23069/5
-- 
To view, visit https://review.coreboot.org/23069
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib23c0ad96f9d8cc30ad357de8c0b0ba967c7d724
Gerrit-Change-Number: 23069
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Thiessen <alex.thiessen.de+coreboot at gmail.com>
Gerrit-Reviewer: Alex Thiessen <alex.thiessen.de+coreboot at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180104/4a9bfc45/attachment.html>


More information about the coreboot-gerrit mailing list