[coreboot-gerrit] Change in coreboot[master]: mainboard/google/poppy/variants/nautilus - MIPI camera asl files for ...

[Rizwan Qureshi (Code Review)]

Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/23056 )

Change subject: mainboard/google/poppy/variants/nautilus - MIPI camera asl files for Nautilus
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/23056/2/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/mipi_camera.asl
File src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/mipi_camera.asl:

https://review.coreboot.org/#/c/23056/2/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/mipi_camera.asl@338
PS2, Line 338: /* Increment only if VSIC < 4 */
             : 					If (LLess (VSIC, 4)) {
> For nautilus, this reference count will come down to 3 ideally (CAM0, VCM, NVM). […]
This value should still be OK. No need to change here. We would have to worry only if we add a 5th device.



-- 
To view, visit https://review.coreboot.org/23056
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebd41ac3631829bbb0b008761eb67c3db3e94638
Gerrit-Change-Number: 23056
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward #1001830
Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani at intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 02 Jan 2018 08:57:19 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180102/f79bcb97/attachment.html>