[coreboot-gerrit] Change in coreboot[master]: ec/google/chromeec: Add note before error message

Martin Roth (Code Review) gerrit at coreboot.org
Wed Feb 28 19:08:17 CET 2018


Martin Roth has uploaded this change for review. ( https://review.coreboot.org/24914


Change subject: ec/google/chromeec: Add note before error message
......................................................................

ec/google/chromeec: Add note before error message

When clearing events from the EC, an error is returned when we try
to clear an event that doesn't exist.  This is normal, but can
be distracting when trying to track down an error, so add a message
saying that the error is expected.

BUG=None
Test=Build Grunt with SMM debug enabled. See message before
"EC returned error result code 1".

Change-Id: Ib2e684e357e821c795de4b59658432c91a8d63fc
Signed-off-by: Martin Roth <martinroth at google.com>
---
M src/ec/google/chromeec/smihandler.c
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/24914/1

diff --git a/src/ec/google/chromeec/smihandler.c b/src/ec/google/chromeec/smihandler.c
index 54aa4bf..cab7192 100644
--- a/src/ec/google/chromeec/smihandler.c
+++ b/src/ec/google/chromeec/smihandler.c
@@ -53,6 +53,7 @@
 	while (google_chromeec_get_event() != 0)
 		;
 
+	printk(BIOS_DEBUG,"Clearing pending EC events. Error code 1 is expected.\n");
 	while (google_chromeec_get_mkbp_event(&mkbp_event) == 0)
 		;
 }

-- 
To view, visit https://review.coreboot.org/24914
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2e684e357e821c795de4b59658432c91a8d63fc
Gerrit-Change-Number: 24914
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180228/098b2118/attachment.html>


More information about the coreboot-gerrit mailing list