[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nami: Enable elan touchscreen

Martin Roth (Code Review) gerrit at coreboot.org
Wed Feb 28 18:37:00 CET 2018


Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/23872 )

Change subject: mb/google/poppy/variants/nami: Enable elan touchscreen
......................................................................

mb/google/poppy/variants/nami: Enable elan touchscreen

BUG=b:72062694
BRANCH=master
TEST=Verify touchscreen on nami works with this change.

Change-Id: Iaec71a11121b3d2849f12d18cda0e506be2ace09
Signed-off-by: Crystal Lin <crystal_lin at compal.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/23872
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Furquan Shaikh <furquan at google.com>
---
M src/mainboard/google/poppy/variants/nami/devicetree.cb
1 file changed, 14 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved



diff --git a/src/mainboard/google/poppy/variants/nami/devicetree.cb b/src/mainboard/google/poppy/variants/nami/devicetree.cb
index b830912..c4aabcf 100644
--- a/src/mainboard/google/poppy/variants/nami/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/nami/devicetree.cb
@@ -243,7 +243,20 @@
 		device pci 14.0 on  end # USB xHCI
 		device pci 14.1 off end # USB xDCI (OTG)
 		device pci 14.2 on  end # Thermal Subsystem
-		device pci 15.0 on  end # I2C #0
+		device pci 15.0 on
+			chip drivers/i2c/generic
+				register "hid" = ""ELAN0001""
+				register "desc" = ""ELAN Touchscreen""
+				register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_E7_IRQ)"
+				register "probed" = "1"
+				register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_B3)"
+				register "reset_delay_ms" = "20"
+				register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C22)"
+				register "enable_delay_ms" = "1"
+				register "has_power_resource" = "1"
+				device i2c 10 on end
+			end
+		end # I2C #0
 		device pci 15.1 on
 			chip drivers/i2c/generic
 				register "hid" = ""ELAN0000""

-- 
To view, visit https://review.coreboot.org/23872
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaec71a11121b3d2849f12d18cda0e506be2ace09
Gerrit-Change-Number: 23872
Gerrit-PatchSet: 3
Gerrit-Owner: Crystal Lin <crystal_lin at compal.corp-partner.google.com>
Gerrit-Reviewer: Crystal Lin <crystal_lin at compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Jimmy M Wang <jimmym_wang at compal.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180228/9ecb3178/attachment.html>


More information about the coreboot-gerrit mailing list