[coreboot-gerrit] Change in coreboot[master]: drivers/tpm: Add TPM ramstage driver for devices without vboot.

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/24905 )

Change subject: drivers/tpm: Add TPM ramstage driver for devices without vboot.
......................................................................


Patch Set 3:

(2 comments)

https://review.coreboot.org/#/c/24905/3/src/drivers/tpm/Kconfig
File src/drivers/tpm/Kconfig:

https://review.coreboot.org/#/c/24905/3/src/drivers/tpm/Kconfig@4
PS3, Line 4: 	depends on !VBOOT
> Could you please add some documentation here explaining what the purpose of this config is?
Ack


https://review.coreboot.org/#/c/24905/3/src/drivers/tpm/tpm.c
File src/drivers/tpm/tpm.c:

https://review.coreboot.org/#/c/24905/3/src/drivers/tpm/tpm.c@21
PS3, Line 21: #include <security/tpm/tspi.h>
> Doesn't seem all these #includes are necessary.
Ack



-- 
To view, visit https://review.coreboot.org/24905
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7536c9734732aeaa85ccc7916c12eecb9ca26b2e
Gerrit-Change-Number: 24905
Gerrit-PatchSet: 3
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 27 Feb 2018 22:43:06 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180227/6ffe7fbd/attachment.html>