[coreboot-gerrit] Change in coreboot[master]: security/vboot: Interface FSP 2.0 mrc caching

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/24904 )

Change subject: security/vboot: Interface FSP 2.0 mrc caching
......................................................................


Patch Set 3:

(2 comments)

https://review.coreboot.org/#/c/24904/3/src/drivers/intel/fsp2_0/include/fsp/memory_init.h
File src/drivers/intel/fsp2_0/include/fsp/memory_init.h:

https://review.coreboot.org/#/c/24904/3/src/drivers/intel/fsp2_0/include/fsp/memory_init.h@18
PS3, Line 18: 
> #include the header which defines the types you use.
Ack


https://review.coreboot.org/#/c/24904/3/src/security/vboot/mrc_cache_hash_tpm.c
File src/security/vboot/mrc_cache_hash_tpm.c:

https://review.coreboot.org/#/c/24904/3/src/security/vboot/mrc_cache_hash_tpm.c@4
PS3, Line 4:  * Copyright (C) 2018 Facebook Inc
> Pretty usre it's not just facebook
Ack



-- 
To view, visit https://review.coreboot.org/24904
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I41a458186c7981adaf3fea8974adec2ca8668f14
Gerrit-Change-Number: 24904
Gerrit-PatchSet: 3
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 27 Feb 2018 22:42:25 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180227/aba825b3/attachment.html>