[coreboot-gerrit] Change in coreboot[master]: security/tpm: Refactor TSS 1.2 and 2.0 implementation

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/22374 )

Change subject: security/tpm: Refactor TSS 1.2 and 2.0 implementation
......................................................................


Patch Set 42:

(3 comments)

https://review.coreboot.org/#/c/22374/25/src/drivers/intel/fsp2_0/memory_init.c
File src/drivers/intel/fsp2_0/memory_init.c:

https://review.coreboot.org/#/c/22374/25/src/drivers/intel/fsp2_0/memory_init.c@38
PS25, Line 38: __attribute__((weak)) void mrc_cache_update_hash(const uint8_t *data,
> Done
Does not compute build issues


https://review.coreboot.org/#/c/22374/39/src/drivers/intel/fsp2_0/memory_init.c
File src/drivers/intel/fsp2_0/memory_init.c:

https://review.coreboot.org/#/c/22374/39/src/drivers/intel/fsp2_0/memory_init.c@38
PS39, Line 38: __attribute__((weak)) void mrc_cache_update_hash(const uint8_t *data,
> I assume you're planning to add other methods to store the MRC hash? Otherwise, using a weak functio […]
Yep that was my idea.


https://review.coreboot.org/#/c/22374/39/src/security/tpm/Kconfig
File src/security/tpm/Kconfig:

https://review.coreboot.org/#/c/22374/39/src/security/tpm/Kconfig@18
PS39, Line 18: 
> And now that I think of it, I don't think it really make sense to let the user decide between TPM-1. […]
Now we have both options. User mode for pluggable TPMs and board mode.



-- 
To view, visit https://review.coreboot.org/22374
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I97bbc7b7b025500b49c743b0c303543c33627c88
Gerrit-Change-Number: 22374
Gerrit-PatchSet: 42
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Andrey Pronin <apronin at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Randall Spangler <randall at spanglers.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 27 Feb 2018 14:43:03 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180227/dde1dd4d/attachment.html>