[coreboot-gerrit] Change in coreboot[master]: soc/amd/common: Save the UMA settings from AGESA

Marc Jones (Code Review) gerrit at coreboot.org
Mon Feb 19 21:26:34 CET 2018


Marc Jones has uploaded this change for review. ( https://review.coreboot.org/23818


Change subject: soc/amd/common: Save the UMA settings from AGESA
......................................................................

soc/amd/common: Save the UMA settings from AGESA

Save the UMA base and size settings returned by AGESA
in amdinitpost();

Change-Id: Id96cc65582118ad41d397b1a600cab1615676a55
Signed-off-by: Marc Jones <marcj303 at gmail.com>
---
M 3rdparty/blobs
M src/soc/amd/common/block/pi/agesawrapper.c
2 files changed, 7 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/23818/1

diff --git a/3rdparty/blobs b/3rdparty/blobs
index 19dea8d..a5efee5 160000
--- a/3rdparty/blobs
+++ b/3rdparty/blobs
@@ -1 +1 @@
-Subproject commit 19dea8d171544f01f12ee6b78af0cc356ab994aa
+Subproject commit a5efee5fdea55f398decc9cabebce3744bbd8147
diff --git a/src/soc/amd/common/block/pi/agesawrapper.c b/src/soc/amd/common/block/pi/agesawrapper.c
index dca7222..cfa3760 100644
--- a/src/soc/amd/common/block/pi/agesawrapper.c
+++ b/src/soc/amd/common/block/pi/agesawrapper.c
@@ -26,6 +26,7 @@
 #include <amdblocks/s3_resume.h>
 #include <amdblocks/agesawrapper.h>
 #include <amdblocks/BiosCallOuts.h>
+#include <soc/southbridge.h>
 
 void __attribute__((weak)) SetMemParams(AMD_POST_PARAMS *PostParams) {}
 void __attribute__((weak)) OemPostParams(AMD_POST_PARAMS *PostParams) {}
@@ -207,12 +208,16 @@
 	 * higher than UmaBase. With UMA_NONE we see UmaBase==0.
 	 */
 	uintptr_t top;
-	if (PostParams->MemConfig.UmaBase)
+	if (PostParams->MemConfig.UmaBase &&
+			(PostParams->MemConfig.UmaBase < ((4ull * GiB) >> 16)))
 		top = PostParams->MemConfig.UmaBase << 16;
 	else
 		top = PostParams->MemConfig.Sub4GCacheTop;
 	backup_top_of_low_cacheable(top);
 
+	save_uma_size(PostParams->MemConfig.UmaSize * 64 * KiB);
+	save_uma_base((u64)PostParams->MemConfig.UmaBase * 64 * KiB);
+
 	print_init_post_settings(PostParams);
 
 	if (status != AGESA_SUCCESS)

-- 
To view, visit https://review.coreboot.org/23818
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id96cc65582118ad41d397b1a600cab1615676a55
Gerrit-Change-Number: 23818
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180219/c5749b60/attachment.html>


More information about the coreboot-gerrit mailing list