[coreboot-gerrit] Change in coreboot[master]: Fizz: Check HDMI HPD and DisplayPort HPD

Daisuke Nojiri (Code Review) gerrit at coreboot.org
Sun Feb 18 02:16:52 CET 2018


Hello Julius Werner, Furquan Shaikh, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/23803

to look at the new patch set (#2).

Change subject: Fizz: Check HDMI HPD and DisplayPort HPD
......................................................................

Fizz: Check HDMI HPD and DisplayPort HPD

Some type-c monitors do not immediately assert HPD. If we continue
to boot without HPD asserted, Depthcharge fails to show pictures
on a monitor even if HPD is asserted later.

Also, if HDMI monitor is connected, no wait is needed. If only HDMI
monitor is connected, the API always loops until stopwatch expires.

This patch will make google_chromeec_wait_for_displayport first check
HDMI HPD. If it's asserted, it returns immediately. If not, it loops
until DP HPD is asserted.

This patch also extends the wait time to 3 seconds.

BUG=b:72387533
BRANCH=none
TEST=Verify firmware screen is displayed even when a type-c monitor
does not imeediately assert HPD. Verify if HDMI monitor is connected,
AP does not wait (and firmware screen is displayed on HDMI monitor).

Change-Id: I8f80c3058b0d4ddc5056d20688e794cd8415da2d
Signed-off-by: Daisuke Nojiri <dnojiri at chromium.org>
---
M src/mainboard/google/fizz/ramstage.c
1 file changed, 38 insertions(+), 2 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/23803/2
-- 
To view, visit https://review.coreboot.org/23803
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8f80c3058b0d4ddc5056d20688e794cd8415da2d
Gerrit-Change-Number: 23803
Gerrit-PatchSet: 2
Gerrit-Owner: Daisuke Nojiri <dnojiri at chromium.org>
Gerrit-Reviewer: Daisuke Nojiri <dnojiri at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180218/32fc315f/attachment.html>


More information about the coreboot-gerrit mailing list