[coreboot-gerrit] Change in coreboot[master]: chromeec: Make google_chromeec_wait_for_display wait for HPD

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/23801 )

Change subject: chromeec: Make google_chromeec_wait_for_display wait for HPD
......................................................................


Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/23801/1/src/ec/google/chromeec/ec.c
File src/ec/google/chromeec/ec.c:

https://review.coreboot.org/#/c/23801/1/src/ec/google/chromeec/ec.c@999
PS1, Line 999: 	return google_chromeec_command(&cmd) == EC_RES_SUCCESS ? 1 : 0;
Should this also return 1 (true), 0 (false) or -1 (error) for consistency with get_amode()?


https://review.coreboot.org/#/c/23801/1/src/ec/google/chromeec/ec.c@1003
PS1, Line 1003: other monitor port (e.g. HDMI) is used
The second part here doesn't sound great. I think it's fine to let the timeout expire if we have no monitor at all, but if we have HDMI attached it should really not need to wait. Doesn't get_amode() return an SID for HDMI that you could check for so you can abort when you see that?


https://review.coreboot.org/#/c/23801/1/src/ec/google/chromeec/ec_commands.h
File src/ec/google/chromeec/ec_commands.h:

https://review.coreboot.org/#/c/23801/1/src/ec/google/chromeec/ec_commands.h@4423
PS1, Line 4423: #define EC_CMD_GET_HPD 0x0121
I do not see this landed in the EC source tree? Again please never touch ec_commands.h directly in a downstream repository like coreboot. Instead, always land the change in the EC repository first, then copy the whole file from the ToT EC repository over to coreboot (preferably as a separate commit).



-- 
To view, visit https://review.coreboot.org/23801
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07aee3bcca3bca93db66578014500b578402a4de
Gerrit-Change-Number: 23801
Gerrit-PatchSet: 1
Gerrit-Owner: Daisuke Nojiri <dnojiri at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sat, 17 Feb 2018 04:26:53 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180217/c2ca2bfe/attachment.html>