[coreboot-gerrit] Change in coreboot[master]: soc/nvidia/tegra210: add missing bl31 params to ATF config

[Andre Heider (Code Review)]

Andre Heider has posted comments on this change. ( https://review.coreboot.org/23783 )

Change subject: soc/nvidia/tegra210: add missing bl31 params to ATF config
......................................................................


Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/23783/3/src/soc/nvidia/tegra210/arm_tf.c
File src/soc/nvidia/tegra210/arm_tf.c:

https://review.coreboot.org/#/c/23783/3/src/soc/nvidia/tegra210/arm_tf.c@46
PS3, Line 46: 	switch (console_uart_get_id()) {
> I don't really care, whatever you prefer
Okay, so lets keep it this way then. The switch statement has the bonus of additional compiler checks in case the enum gets changed in the future.
Thanks for the reviews!



-- 
To view, visit https://review.coreboot.org/23783
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a47647216a154894e6c2c1fd3b304e18e85c6a5
Gerrit-Change-Number: 23783
Gerrit-PatchSet: 3
Gerrit-Owner: Andre Heider <a.heider at gmail.com>
Gerrit-Reviewer: Andre Heider <a.heider at gmail.com>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 16 Feb 2018 21:41:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180216/dfc3e606/attachment.html>