[coreboot-gerrit] Change in coreboot[master]: soc/nvidia/tegra210: add missing bl31 params

Andre Heider (Code Review) gerrit at coreboot.org
Fri Feb 16 05:22:59 CET 2018


Andre Heider has posted comments on this change. ( https://review.coreboot.org/23783 )

Change subject: soc/nvidia/tegra210: add missing bl31 params
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/23783/1/src/soc/nvidia/tegra210/arm_tf.c
File src/soc/nvidia/tegra210/arm_tf.c:

https://review.coreboot.org/#/c/23783/1/src/soc/nvidia/tegra210/arm_tf.c@45
PS1, Line 45: 	t210_plat_params.uart_id = 1;
> Shouldn't this depend on the CONSOLE_SERIAL_TEGRA210_UARTx Kconfigs?
It should, yes ;)

But this was just the first step without functional change. UARTA is currently hard wired, see e.g. src/soc/nvidia/tegra210/clock.c:clock_early_uart()

I have follow up patches which need a bit of polishing, but the end result is a working serial based on CONSOLE_SERIAL_TEGRA210_UARTx



-- 
To view, visit https://review.coreboot.org/23783
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a47647216a154894e6c2c1fd3b304e18e85c6a5
Gerrit-Change-Number: 23783
Gerrit-PatchSet: 1
Gerrit-Owner: Andre Heider <a.heider at gmail.com>
Gerrit-Reviewer: Andre Heider <a.heider at gmail.com>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 16 Feb 2018 04:22:59 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180216/6fca54ae/attachment.html>


More information about the coreboot-gerrit mailing list