[coreboot-gerrit] Change in coreboot[master]: mb/scaleway/tagada: Remove unused board_id

Julien Viard de Galbert (Code Review) gerrit at coreboot.org
Tue Feb 13 23:20:49 CET 2018


Julien Viard de Galbert has uploaded this change for review. ( https://review.coreboot.org/23741


Change subject: mb/scaleway/tagada: Remove unused board_id
......................................................................

mb/scaleway/tagada: Remove unused board_id

Change-Id: I6175ce3d3ef739c4f503db826036ffe8feff9ddc
Signed-off-by: Julien Viard de Galbert <jviarddegalbert at online.net>
---
M src/mainboard/scaleway/tagada/Makefile.inc
D src/mainboard/scaleway/tagada/boardid.c
D src/mainboard/scaleway/tagada/harcuvar_boardid.h
3 files changed, 0 insertions(+), 57 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/23741/1

diff --git a/src/mainboard/scaleway/tagada/Makefile.inc b/src/mainboard/scaleway/tagada/Makefile.inc
index 7421f38..2c8186f 100644
--- a/src/mainboard/scaleway/tagada/Makefile.inc
+++ b/src/mainboard/scaleway/tagada/Makefile.inc
@@ -14,11 +14,9 @@
 ## GNU General Public License for more details.
 ##
 
-romstage-y += boardid.c
 romstage-y += hsio.c
 
 ramstage-y += ramstage.c
-ramstage-y += boardid.c
 ramstage-y += hsio.c
 ramstage-$(CONFIG_HAVE_ACPI_TABLES) += acpi_tables.c
 ramstage-$(CONFIG_HAVE_ACPI_TABLES) += fadt.c
diff --git a/src/mainboard/scaleway/tagada/boardid.c b/src/mainboard/scaleway/tagada/boardid.c
deleted file mode 100644
index c9df766..0000000
--- a/src/mainboard/scaleway/tagada/boardid.c
+++ /dev/null
@@ -1,29 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2015 - 2017 Intel Corporation.
- * Copyright (C) 2017 - 2018 Online SAS.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- */
-
-#include <console/console.h>
-
-#include "harcuvar_boardid.h"
-
-uint8_t board_id(void)
-{
-	int id = BoardIdHarcuvar;
-
-	printk(BIOS_SPEW, "Board ID: %#x.\n", id);
-
-	return id;
-}
diff --git a/src/mainboard/scaleway/tagada/harcuvar_boardid.h b/src/mainboard/scaleway/tagada/harcuvar_boardid.h
deleted file mode 100644
index 3bcd60c..0000000
--- a/src/mainboard/scaleway/tagada/harcuvar_boardid.h
+++ /dev/null
@@ -1,26 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2015 - 2017 Intel Corporation.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- */
-
-#ifndef HARCUVAR_MAINBOARD_BOARD_H
-#define HARCUVAR_MAINBOARD_BOARD_H
-
-#include <stdint.h>
-
-#define BoardIdHarcuvar 0x52
-
-uint8_t board_id(void);
-
-#endif /* MAINBOARD_BOARD_H */

-- 
To view, visit https://review.coreboot.org/23741
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6175ce3d3ef739c4f503db826036ffe8feff9ddc
Gerrit-Change-Number: 23741
Gerrit-PatchSet: 1
Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert at online.net>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180213/d7a4d5c1/attachment.html>


More information about the coreboot-gerrit mailing list