[coreboot-gerrit] Change in coreboot[master]: mb/scaleway/tagada: Remove eMMC configuration

[Julien Viard de Galbert (Code Review)]

Julien Viard de Galbert has uploaded this change for review. ( https://review.coreboot.org/23739


Change subject: mb/scaleway/tagada: Remove eMMC configuration
......................................................................

mb/scaleway/tagada: Remove eMMC configuration

The board does no support eMMC so no need to configure it.

Change-Id: If29009a09f39484b1da16fb650b4f9cbee2a6d19
Signed-off-by: Julien Viard de Galbert <jviarddegalbert at online.net>
---
D src/mainboard/scaleway/tagada/emmc.h
M src/mainboard/scaleway/tagada/ramstage.c
2 files changed, 3 insertions(+), 67 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/23739/1

diff --git a/src/mainboard/scaleway/tagada/emmc.h b/src/mainboard/scaleway/tagada/emmc.h
deleted file mode 100644
index 9832191..0000000
--- a/src/mainboard/scaleway/tagada/emmc.h
+++ /dev/null
@@ -1,34 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2016 - 2017 Intel Corporation.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- */
-
-#ifndef _MAINBOARD_EMMC_H
-#define _MAINBOARD_EMMC_H
-
-#include <fsp/util.h>
-
-#define DEFAULT_EMMC_DLL_SIGN 0x55aa
-
-#ifndef __ACPI__
-BL_EMMC_INFORMATION harcuvar_emmc_config[] = {
-	/*
-	 *  Default eMMC DLL configuration.
-	 */
-	{DEFAULT_EMMC_DLL_SIGN,
-	 {0x00000508, 0x00000c11, 0x1c2a2a2a, 0x00191e27, 0x00000a0a,
-	  0x00010013, 0x00000001} } };
-#endif
-
-#endif /* _MAINBOARD_EMMC_H */
diff --git a/src/mainboard/scaleway/tagada/ramstage.c b/src/mainboard/scaleway/tagada/ramstage.c
index 4d90858..0aa6f13 100644
--- a/src/mainboard/scaleway/tagada/ramstage.c
+++ b/src/mainboard/scaleway/tagada/ramstage.c
@@ -2,6 +2,7 @@
  * This file is part of the coreboot project.
  *
  * Copyright (C) 2014 - 2017 Intel Corporation
+ * Copyright (C) 2017 - 2018 Online SAS.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -17,40 +18,9 @@
 #include <console/console.h>
 #include <fsp/api.h>
 #include <soc/ramstage.h>
-#include "emmc.h"
-
-static int get_emmc_dll_info(uint16_t signature, size_t num_of_entry,
-			     BL_EMMC_INFORMATION **config)
-{
-	uint8_t entry;
-
-	if ((signature == 0) || (num_of_entry == 0) || (*config == NULL))
-		return 1;
-
-	for (entry = 0; entry < num_of_entry; entry++) {
-		if ((*config)[entry].Signature == signature) {
-			*config = &(*config)[entry];
-			return 0;
-		}
-	}
-
-	return 1;
-}
 
 void mainboard_silicon_init_params(FSPS_UPD *params)
 {
-	size_t num;
-	uint16_t emmc_dll_sign;
-	BL_EMMC_INFORMATION *emmc_config;
-
-	/* Configure eMMC DLL PCD */
-	emmc_dll_sign = DEFAULT_EMMC_DLL_SIGN;
-	num = ARRAY_SIZE(harcuvar_emmc_config);
-	emmc_config = harcuvar_emmc_config;
-
-	if (get_emmc_dll_info(emmc_dll_sign, num, &emmc_config))
-		die("eMMC DLL Configuration is invalid, please correct it!");
-
-	params->FspsConfig.PcdEMMCDLLConfigPtr =
-		(uint32_t)&emmc_config->eMMCDLLConfig;
+	/* Disable eMMC */
+	params->FspsConfig.PcdEnableEmmc = 0;
 }

-- 
To view, visit https://review.coreboot.org/23739
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If29009a09f39484b1da16fb650b4f9cbee2a6d19
Gerrit-Change-Number: 23739
Gerrit-PatchSet: 1
Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert at online.net>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180213/9f4f4f0f/attachment-0001.html>