[coreboot-gerrit] Change in coreboot[master]: driver/uart: Reintroduce default_baudrate as weak function.

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/23713 )

Change subject: driver/uart: Reintroduce default_baudrate as weak function.
......................................................................


Patch Set 1:

> Hello, you were involved in the commit I partially revert, so I'm
 > adding you.
 > 
 > Also I could do it by adding an config option to not reintroduce
 > the function by default.
 > 
 > Best Regards

The rationale behind removing this was that nobody seems to use it, that it is confusing to have both a cmos setting and a Kconfig to do the same thing and that when fetching the baud rate from cmos it actually tried to print stuff before baud rate was set which could result in very long delays in the boot time.

To avoid having a something override the value defined in Kconfig (to avoid confusion) I think it would be better to not have it show this option in Kconfig at all. something like MAINBOARD_SET_KCONFIG which is mutually exlusive with TTYS0_BAUD...


-- 
To view, visit https://review.coreboot.org/23713
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I970ee788bf90b9e1a8c6ccdc5eee8029d9af0ecc
Gerrit-Change-Number: 23713
Gerrit-PatchSet: 1
Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert at online.net>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Julien Viard de Galbert <jviarddegalbert at online.net>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 12 Feb 2018 15:45:04 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180212/8cc8b2dc/attachment.html>