[coreboot-gerrit] Change in coreboot[master]: mb/emu/spike-riscv: Move usage instructions into Kconfig help
Jonathan Neuschäfer (Code Review)
gerrit at coreboot.org
Mon Feb 12 13:12:20 CET 2018
Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/23708
Change subject: mb/emu/spike-riscv: Move usage instructions into Kconfig help
......................................................................
mb/emu/spike-riscv: Move usage instructions into Kconfig help
... and fix them in the process.
The Kconfig help text seems to be a slightly better place for such
documentation than a comment in Kconfig.
Change-Id: I4114e17ad9c486a9de059040b0e2821540c31aad
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
---
M src/mainboard/emulation/spike-riscv/Kconfig
M src/mainboard/emulation/spike-riscv/Kconfig.name
2 files changed, 5 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/23708/1
diff --git a/src/mainboard/emulation/spike-riscv/Kconfig b/src/mainboard/emulation/spike-riscv/Kconfig
index ab5e7c9..67161f3 100644
--- a/src/mainboard/emulation/spike-riscv/Kconfig
+++ b/src/mainboard/emulation/spike-riscv/Kconfig
@@ -12,9 +12,6 @@
## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
## GNU General Public License for more details.
-# To execute, do:
-# qemu-system-arm -M vexpress-a9 -m 1024M -nographic -kernel build/coreboot.rom
-
if BOARD_EMULATION_SPIKE_UCB_RISCV
config BOARD_SPECIFIC_OPTIONS # dummy
diff --git a/src/mainboard/emulation/spike-riscv/Kconfig.name b/src/mainboard/emulation/spike-riscv/Kconfig.name
index 36dd509..66266f7 100644
--- a/src/mainboard/emulation/spike-riscv/Kconfig.name
+++ b/src/mainboard/emulation/spike-riscv/Kconfig.name
@@ -1,2 +1,7 @@
config BOARD_EMULATION_SPIKE_UCB_RISCV
bool "SPIKE ucb riscv"
+ help
+ To run coreboot in spike:
+ * run "make" as usual
+ * util/riscvtools/make-spike-elf.sh build/coreboot.{rom,elf}
+ * spike -m1024 build/coreboot.elf
--
To view, visit https://review.coreboot.org/23708
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4114e17ad9c486a9de059040b0e2821540c31aad
Gerrit-Change-Number: 23708
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180212/c242a915/attachment.html>
More information about the coreboot-gerrit
mailing list