[coreboot-gerrit] Change in coreboot[master]: ec/chromeec: Fix battery ACPI mutex level

Matt DeVillier (Code Review) gerrit at coreboot.org
Sun Feb 11 23:08:51 CET 2018


Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/23697


Change subject: ec/chromeec: Fix battery ACPI mutex level
......................................................................

ec/chromeec: Fix battery ACPI mutex level

Commit 07fe618 [chromeec: Add support for reading second battery info]
added a Mutex as part of the ACPI code to determine battery statuses.

Windows is extremely picky about ACPI code, and attempting to acquire
a level 1 mutex without first having acquired a level 0 mutex causes
Windows to hang on boot. Since there's no reason to use a level 1
mutex here, change it to level 0.

Test: Boot Windows on device with ChromeEC without hanging

Change-Id: Icfb0817cfe0c49eb4527a12b507362939a6d32c6
Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
M src/ec/google/chromeec/acpi/battery.asl
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/23697/1

diff --git a/src/ec/google/chromeec/acpi/battery.asl b/src/ec/google/chromeec/acpi/battery.asl
index d8056b0..0a0caec 100644
--- a/src/ec/google/chromeec/acpi/battery.asl
+++ b/src/ec/google/chromeec/acpi/battery.asl
@@ -17,7 +17,7 @@
 // Scope (EC0)
 
 /* Mutex for EC battery index interface */
-Mutex (BATM, 1)
+Mutex (BATM, 0)
 
 // Wait for desired battery index to be presented in shared memory
 //   Arg0 = battery index

-- 
To view, visit https://review.coreboot.org/23697
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icfb0817cfe0c49eb4527a12b507362939a6d32c6
Gerrit-Change-Number: 23697
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180211/6c34ae1c/attachment.html>


More information about the coreboot-gerrit mailing list