[coreboot-gerrit] Change in coreboot[master]: southbridge/amd/agesa/hudson: don't put apu/amdfw without blobs to CBFS

Mike Banon (Code Review) gerrit at coreboot.org
Sun Feb 11 12:34:16 CET 2018


Mike Banon has uploaded this change for review. ( https://review.coreboot.org/23692


Change subject: southbridge/amd/agesa/hudson: don't put apu/amdfw without blobs to CBFS
......................................................................

southbridge/amd/agesa/hudson: don't put apu/amdfw without blobs to CBFS

Currently, when no blobs are selected, empty apu/amdfw area (full of 0xFF)
is being included to the CBFS - thus wasting 4096 bytes. After this commit
apu/amdfw will be created only if there are blobs chosen to be installed

Change-Id: I3b8c796ccceec4abc1f16fee9111caf1ec5eb892
Signed-off-by: Mike Banon <mikebdp2 at gmail.com>
---
M src/southbridge/amd/agesa/hudson/Makefile.inc
1 file changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/23692/1

diff --git a/src/southbridge/amd/agesa/hudson/Makefile.inc b/src/southbridge/amd/agesa/hudson/Makefile.inc
index 2bf6f02..4ac48f3 100644
--- a/src/southbridge/amd/agesa/hudson/Makefile.inc
+++ b/src/southbridge/amd/agesa/hudson/Makefile.inc
@@ -48,6 +48,8 @@
 pci$(stripped_ahci_rom_id).rom-required := Hudson AHCI Option ROM (Contact your AMD representative)
 endif
 
+ifneq ($(CONFIG_HUDSON_XHCI_FWM_FILE)$(CONFIG_HUDSON_IMC_FWM_FILE)$(CONFIG_HUDSON_GEC_FWM_FILE),)
+
 add_opt_prefix=$(if $(call strip_quotes, $(1)), $(2) $(call strip_quotes, $(1)), )
 
 OPT_HUDSON_XHCI_FWM_FILE=$(call add_opt_prefix, $(CONFIG_HUDSON_XHCI_FWM_FILE), --xhci)
@@ -71,3 +73,5 @@
 apu/amdfw-file := $(obj)/amdfw.rom
 apu/amdfw-position := $(HUDSON_FWM_POSITION)
 apu/amdfw-type := raw
+
+endif

-- 
To view, visit https://review.coreboot.org/23692
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b8c796ccceec4abc1f16fee9111caf1ec5eb892
Gerrit-Change-Number: 23692
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Banon <mikebdp2 at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180211/9ecb4613/attachment.html>


More information about the coreboot-gerrit mailing list