[coreboot-gerrit] Change in coreboot[master]: libpayload/drivers/usb: Fix broken retry counter
Nico Huber (Code Review)
gerrit at coreboot.org
Sat Feb 10 14:52:24 CET 2018
Nico Huber has posted comments on this change. ( https://review.coreboot.org/23688 )
Change subject: libpayload/drivers/usb: Fix broken retry counter
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/#/c/23688/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/23688/1//COMMIT_MSG@7
PS1, Line 7: libpayload/drivers/usb
maybe just "libpayload/usb:"
https://review.coreboot.org/#/c/23688/1/payloads/libpayload/drivers/usb/usb.c
File payloads/libpayload/drivers/usb/usb.c:
https://review.coreboot.org/#/c/23688/1/payloads/libpayload/drivers/usb/usb.c@180
PS1, Line 180: return len;
Simpler:
if (ret == len)
break;
udelay(10);
--
To view, visit https://review.coreboot.org/23688
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c881c08d94636a43223338e46c876b5f3e27d47
Gerrit-Change-Number: 23688
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Shawn Nematbakhsh <shawnn at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sat, 10 Feb 2018 13:52:24 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180210/5d8bde80/attachment.html>
More information about the coreboot-gerrit
mailing list