[coreboot-gerrit] Change in coreboot[master]: libpayload/drivers/usb/uhci: Fix regression

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/23686 )

Change subject: libpayload/drivers/usb/uhci: Fix regression
......................................................................


Patch Set 1: Code-Review+1

(4 comments)

https://review.coreboot.org/#/c/23686/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/23686/1//COMMIT_MSG@7
PS1, Line 7: libpayload/drivers/usb/uhci:
I guess "libpayload/uhci:" would suffice.


https://review.coreboot.org/#/c/23686/1//COMMIT_MSG@7
PS1, Line 7: Fix regression
Please mention what it's actually about, e.g. "Return transferred byte count".


https://review.coreboot.org/#/c/23686/1//COMMIT_MSG@10
PS1, Line 10: introduced a regression on
I would actually call it what it is, i.e. "deliberately broke".
It even says so in the commit message; how the hell could that
get merged?


https://review.coreboot.org/#/c/23686/1/payloads/libpayload/drivers/usb/uhci.c
File payloads/libpayload/drivers/usb/uhci.c:

https://review.coreboot.org/#/c/23686/1/payloads/libpayload/drivers/usb/uhci.c@458
PS1, Line 458: 	return 0;
And here?



-- 
To view, visit https://review.coreboot.org/23686
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I823521e24f6f9e04c86d36fda751c449cd884ce3
Gerrit-Change-Number: 23686
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sat, 10 Feb 2018 13:22:27 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180210/8ad5a978/attachment.html>