[coreboot-gerrit] Change in coreboot[master]: chromeec: Fix ACPI compile warning

[Nicolas Boichat (Code Review)]

Nicolas Boichat has posted comments on this change. ( https://review.coreboot.org/23661 )

Change subject: chromeec: Fix ACPI compile warning
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://review.coreboot.org/#/c/23661/1/src/ec/google/chromeec/acpi/battery.asl
File src/ec/google/chromeec/acpi/battery.asl:

https://review.coreboot.org/#/c/23661/1/src/ec/google/chromeec/acpi/battery.asl@52
PS1, Line 52: }
On dual-battery systems, that will always return an error when asking for the second battery.

Instead, I'd do:

#else
    If (LNotEqual (0, Arg0)) {
        Return (One)
    }
#endif
    Return (Zero)



-- 
To view, visit https://review.coreboot.org/23661
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae12c5d1aa749948ef4025c8b5e60c97e1b747a5
Gerrit-Change-Number: 23661
Gerrit-PatchSet: 1
Gerrit-Owner: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Nicolas Boichat <drinkcat at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 09 Feb 2018 00:01:09 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180209/21f4fd47/attachment.html>