[coreboot-gerrit] Change in coreboot[master]: chromeec: Fix ACPI compile warning

Lijian Zhao (Code Review) gerrit at coreboot.org
Thu Feb 8 22:01:05 CET 2018


Lijian Zhao has uploaded this change for review. ( https://review.coreboot.org/23661


Change subject: chromeec: Fix ACPI compile warning
......................................................................

chromeec: Fix ACPI compile warning

For system without secondary battery, current DSDT will report warning
during build time. Add a conditional check to make sure only battery
index 0 can return success.

TEST=Build pass.

Change-Id: Iae12c5d1aa749948ef4025c8b5e60c97e1b747a5
Signed-off-by: Lijian Zhao <lijian.zhao at intel.com>
---
M src/ec/google/chromeec/acpi/battery.asl
1 file changed, 6 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/23661/1

diff --git a/src/ec/google/chromeec/acpi/battery.asl b/src/ec/google/chromeec/acpi/battery.asl
index 18b612d..8960360 100644
--- a/src/ec/google/chromeec/acpi/battery.asl
+++ b/src/ec/google/chromeec/acpi/battery.asl
@@ -43,7 +43,12 @@
 		}
 	}
 #endif
-	Return (Zero)
+	If (LEqual (0, Arg0)) {
+		Return (Zero)
+	}
+	Else {
+		Return (One)
+	}
 }
 
 // _STA implementation.

-- 
To view, visit https://review.coreboot.org/23661
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae12c5d1aa749948ef4025c8b5e60c97e1b747a5
Gerrit-Change-Number: 23661
Gerrit-PatchSet: 1
Gerrit-Owner: Lijian Zhao <lijian.zhao at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180208/1dc29748/attachment.html>


More information about the coreboot-gerrit mailing list