[coreboot-gerrit] Change in coreboot[master]: mb/google/grunt: Add ADAU7002 to devicetree

Daniel Kurtz (Code Review) gerrit at coreboot.org
Thu Feb 8 20:10:06 CET 2018


Hello Daniel Kurtz,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/23660

to review the following change.


Change subject: mb/google/grunt: Add ADAU7002 to devicetree
......................................................................

mb/google/grunt: Add ADAU7002 to devicetree

Add an entry to the grunt devicetree defining the ADAU7002 PDM-to-I2S
converter.

BUG=b:72121803
TEST=With grunt audio kernel patches, "aplay -l" shows playback devices:
 **** List of PLAYBACK Hardware Devices ****
 card 0: acpd7219m98357 [acpd7219m98357], device 0: Playback da7219-hifi-0 []
   Subdevices: 1/1
   Subdevice #0: subdevice #0
 card 0: acpd7219m98357 [acpd7219m98357], device 2: HiFi Playback HiFi-2 []
   Subdevices: 1/1
   Subdevice #0: subdevice #0

Change-Id: I90b59ec64f4b841932db42b8a8970ed924283613
Signed-off-by: Daniel Kurtz <djkurtz at chromium.org>
---
M src/mainboard/google/kahlee/Kconfig
M src/mainboard/google/kahlee/variants/grunt/devicetree.cb
2 files changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/23660/1

diff --git a/src/mainboard/google/kahlee/Kconfig b/src/mainboard/google/kahlee/Kconfig
index 988afc3..3dd0614 100644
--- a/src/mainboard/google/kahlee/Kconfig
+++ b/src/mainboard/google/kahlee/Kconfig
@@ -124,6 +124,7 @@
 config GRUNT_AUDIO
 	bool
 	default y if !BOARD_GOOGLE_KAHLEE
+	select DRIVERS_GENERIC_ADAU7002
 	select DRIVERS_GENERIC_MAX98357A
 	select DRIVERS_I2C_DA7219
 
diff --git a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb
index 8601af8..55372d4 100644
--- a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb
+++ b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb
@@ -83,6 +83,9 @@
 		device pci 18.5 on  end
 	end #domain
 	device mmio 0xfedc2000 on
+		chip drivers/generic/adau7002
+			device generic 0.0 on end
+		end
 		chip drivers/i2c/da7219
 			register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_14)"
 			register "btn_cfg" = "50"

-- 
To view, visit https://review.coreboot.org/23660
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I90b59ec64f4b841932db42b8a8970ed924283613
Gerrit-Change-Number: 23660
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180208/94e5cd4c/attachment.html>


More information about the coreboot-gerrit mailing list