[coreboot-gerrit] Change in coreboot[master]: mainboard/hp: Add HP Elitebook 8770w
Robert Reeves (Code Review)
gerrit at coreboot.org
Thu Feb 8 15:33:47 CET 2018
Robert Reeves has posted comments on this change. ( https://review.coreboot.org/23651 )
Change subject: mainboard/hp: Add HP Elitebook 8770w
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/23651/1/src/mainboard/hp/8770w/cmos.layout
File src/mainboard/hp/8770w/cmos.layout:
https://review.coreboot.org/#/c/23651/1/src/mainboard/hp/8770w/cmos.layout@91
PS1, Line 91: 6 0 Emergency
: 6 1 Alert
: 6 2 Critical
: 6 3 Error
: 6 4 Warning
: 6 5 Notice
: 6 6 Info
: 6 7 Debug
: 6 8 Spew
Applied the change recommended by Arthur Heymans on the previous version of this submission. Funnily enough, I had never changed this to begin with, that was just how it was on the original file when I started this port in December.
https://review.coreboot.org/#/c/23651/1/src/mainboard/hp/8770w/romstage.c
File src/mainboard/hp/8770w/romstage.c:
https://review.coreboot.org/#/c/23651/1/src/mainboard/hp/8770w/romstage.c@42
PS1, Line 42: {
: }
Got rid of the whitespace here.
--
To view, visit https://review.coreboot.org/23651
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4ff64e9cf0c7a51ac48ca2fe6fe8beab02e9f9a
Gerrit-Change-Number: 23651
Gerrit-PatchSet: 1
Gerrit-Owner: Robert Reeves <xiinc37 at gmail.com>
Gerrit-Reviewer: Robert Reeves <xiinc37 at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 08 Feb 2018 14:33:47 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180208/da1e24f5/attachment.html>
More information about the coreboot-gerrit
mailing list