[coreboot-gerrit] Change in coreboot[master]: google/snappy: enhance BigDaddy USB#2 2.0 strength

Kevin Chiu (Code Review) gerrit at coreboot.org
Thu Feb 8 09:00:32 CET 2018


Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/23649


Change subject: google/snappy: enhance BigDaddy USB#2 2.0 strength
......................................................................

google/snappy: enhance BigDaddy USB#2 2.0 strength

Fine tune 14" BigDaddy USB#2 2.0 strength:
PERPORTPETXISET: 7
PERPORTTXISET: 1
IUSBTXEMPHASISEN: 3
PERPORTTXPEHALF: 0

this value could have USB#2 2.0 EA/function pass.

BUG=b:72922816
BRANCH=reef
TEST=emerge-snappy coreboot
Change-Id: I0ea1b966b7c02c95bf0ea1138a5629fd3b576439
Signed-off-by: Kevin Chiu <Kevin.Chiu at quantatw.com>
---
M src/mainboard/google/reef/variants/snappy/mainboard.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/23649/1

diff --git a/src/mainboard/google/reef/variants/snappy/mainboard.c b/src/mainboard/google/reef/variants/snappy/mainboard.c
index ac76a88..990f483 100644
--- a/src/mainboard/google/reef/variants/snappy/mainboard.c
+++ b/src/mainboard/google/reef/variants/snappy/mainboard.c
@@ -92,7 +92,7 @@
 	case SKU_BIGDADDY_KBDBKLIGHT:
 	case SKU_BIGDADDY:
 		cfg->usb2eye[1].Usb20PerPortPeTxiSet = 7;
-		cfg->usb2eye[1].Usb20PerPortTxiSet = 7;
+		cfg->usb2eye[1].Usb20PerPortTxiSet = 1;
 		cfg->usb2eye[1].Usb20IUsbTxEmphasisEn = 3;
 		cfg->usb2eye[1].Usb20PerPortTxPeHalf = 0;
 		break;

-- 
To view, visit https://review.coreboot.org/23649
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ea1b966b7c02c95bf0ea1138a5629fd3b576439
Gerrit-Change-Number: 23649
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu <Kevin.Chiu at quantatw.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180208/5147c093/attachment-0001.html>


More information about the coreboot-gerrit mailing list