[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nami: Revise AC/DC loadlines

Gaggery Tsai (Code Review) gerrit at coreboot.org
Wed Feb 7 10:17:19 CET 2018


Gaggery Tsai has uploaded this change for review. ( https://review.coreboot.org/23635


Change subject: mb/google/poppy/variants/nami: Revise AC/DC loadlines
......................................................................

mb/google/poppy/variants/nami: Revise AC/DC loadlines

This patch revises AC/DC loadlines from VRTT reports
attached in b/72129954.

+----------------+-------+-------+-------+-------+
| Domain/Setting |  SA   |  IA   | GTUS  |  GTS  |
+----------------+-------+-------+-------+-------+
| AcLoadline     | 11    | 2.4   | 3.1   | 3.1   |
| DcLoadline     | 10    | 2.46  | 3.1   | 3.1   |
+----------------+-------+-------+-------+-------+

BUG=b:72351128
BRANCH=None
TEST=emerge-nami coreboot chromeos-bootimage & ensure the settings
     are passed to FSP.

Change-Id: Ib8aeb82973c42723d7b623967f8085c8f1d926eb
Signed-off-by: Gaggery Tsai <gaggery.tsai at intel.com>
---
M src/mainboard/google/poppy/variants/nami/devicetree.cb
1 file changed, 10 insertions(+), 10 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/23635/1

diff --git a/src/mainboard/google/poppy/variants/nami/devicetree.cb b/src/mainboard/google/poppy/variants/nami/devicetree.cb
index 348f7de..60103ae 100644
--- a/src/mainboard/google/poppy/variants/nami/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/nami/devicetree.cb
@@ -78,8 +78,8 @@
 	#| ImonSlope      | 0     | 0     | 0     | 0     |
 	#| ImonOffset     | 0     | 0     | 0     | 0     |
 	#| VrVoltageLimit | 1.52V | 1.52V | 1.52V | 1.52V |
-	#| AcLoadline     | 15    | 5.7   | 5.5   | 5.5   |
-	#| DcLoadline     | 14.3  | 4.83  | 4.2   | 4.2   |
+	#| AcLoadline     | 11    | 2.4   | 3.1   | 3.1   |
+	#| DcLoadline     | 10    | 2.46  | 3.1   | 3.1   |
 	#+----------------+-------+-------+-------+-------+
 	register "domain_vr_config[VR_SYSTEM_AGENT]" = "{
 		.vr_config_enable = 1,
@@ -91,8 +91,8 @@
 		.imon_slope = 0x0,
 		.imon_offset = 0x0,
 		.voltage_limit = 1520,
-		.ac_loadline = 1500,
-		.dc_loadline = 1430,
+		.ac_loadline = 1100,
+		.dc_loadline = 1000,
 	}"
 
 	register "domain_vr_config[VR_IA_CORE]" = "{
@@ -105,8 +105,8 @@
 		.imon_slope = 0x0,
 		.imon_offset = 0x0,
 		.voltage_limit = 1520,
-		.ac_loadline = 570,
-		.dc_loadline = 483,
+		.ac_loadline = 240,
+		.dc_loadline = 246,
 	}"
 
 	register "domain_vr_config[VR_GT_UNSLICED]" = "{
@@ -119,8 +119,8 @@
 		.imon_slope = 0x0,
 		.imon_offset = 0x0,
 		.voltage_limit = 1520,
-		.ac_loadline = 550,
-		.dc_loadline = 420,
+		.ac_loadline = 310,
+		.dc_loadline = 310,
 	}"
 
 	register "domain_vr_config[VR_GT_SLICED]" = "{
@@ -133,8 +133,8 @@
 		.imon_slope = 0x0,
 		.imon_offset = 0x0,
 		.voltage_limit = 1520,
-		.ac_loadline = 550,
-		.dc_loadline = 420,
+		.ac_loadline = 310,
+		.dc_loadline = 310,
 	}"
 
 	# Root port 4 (x1)

-- 
To view, visit https://review.coreboot.org/23635
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib8aeb82973c42723d7b623967f8085c8f1d926eb
Gerrit-Change-Number: 23635
Gerrit-PatchSet: 1
Gerrit-Owner: Gaggery Tsai <gaggery.tsai at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180207/482fc6eb/attachment.html>


More information about the coreboot-gerrit mailing list