[coreboot-gerrit] Change in coreboot[master]: soc/amd/stoneyridge/acpi/sleepstates.asl: Fix guarded code

Richard Spiegel (Code Review) gerrit at coreboot.org
Fri Feb 2 20:06:38 CET 2018


Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/23575


Change subject: soc/amd/stoneyridge/acpi/sleepstates.asl: Fix guarded code
......................................................................

soc/amd/stoneyridge/acpi/sleepstates.asl: Fix guarded code

Remove #if statement and replace it with if(IS_ENABLED(...)) per coreboot
recommendations.

BUG=b:62200858
TEST=Build kahlee.

Change-Id: I268b228706a625e1415c4f24e808261c279ba41e
Signed-off-by: Richard Spiegel <richard.spiegel at silverbackltd.com>
---
M src/soc/amd/stoneyridge/acpi/sleepstates.asl
1 file changed, 5 insertions(+), 5 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/23575/1

diff --git a/src/soc/amd/stoneyridge/acpi/sleepstates.asl b/src/soc/amd/stoneyridge/acpi/sleepstates.asl
index 2f36738..bdca91e 100644
--- a/src/soc/amd/stoneyridge/acpi/sleepstates.asl
+++ b/src/soc/amd/stoneyridge/acpi/sleepstates.asl
@@ -3,6 +3,7 @@
  *
  * Copyright (C) 2007-2009 coresystems GmbH
  * Copyright (C) 2011 The ChromiumOS Authors.  All rights reserved.
+ * Copyright (C) 2018 Advanced Micro Devices, Inc.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -15,11 +16,10 @@
  */
 
 /* S1 support: bit 0, S2 Support: bit 1, etc. S0 & S5 assumed */
-#if IS_ENABLED(CONFIG_HAVE_ACPI_RESUME)
-Name (SSFG, 0x0D)
-#else
-Name (SSFG, 0x09)
-#endif
+Name(SSFG, 0x09)
+if (IS_ENABLED(CONFIG_HAVE_ACPI_RESUME)) {
+	Store(0x0D, SSFG)
+}
 
 /* Supported sleep states: */
 Name(\_S0, Package () {0x00, 0x00, 0x00, 0x00} )	/* (S0) - working state */

-- 
To view, visit https://review.coreboot.org/23575
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I268b228706a625e1415c4f24e808261c279ba41e
Gerrit-Change-Number: 23575
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180202/3060b29d/attachment.html>


More information about the coreboot-gerrit mailing list