[coreboot-gerrit] Change in coreboot[master]: google/scarlet: Innolux P097PFG panel use new version initial code

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/23561 )

Change subject: google/scarlet: Innolux P097PFG panel use new version initial code
......................................................................


Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/23561/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/23561/1//COMMIT_MSG@13
PS1, Line 13: BUG=b:69689064, b:72191820
This is wrong btw, we don't intend to use the gru branch for Scarlet.


https://review.coreboot.org/#/c/23561/1//COMMIT_MSG@12
PS1, Line 12: 
            : BUG=b:69689064, b:72191820
            : BRANCH=gru
> Last time i do not add these tags and Julius request me to add it back. So i think we need it.
Yeah... they are no required, but allowed and encouraged where they provide value.



-- 
To view, visit https://review.coreboot.org/23561
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9679c4f7f706fd6cd2e1dba7ec79e772fe3f227a
Gerrit-Change-Number: 23561
Gerrit-PatchSet: 2
Gerrit-Owner: Lin Huang <hl at rock-chips.com>
Gerrit-Reviewer: Brian Norris <briannorris at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Lin Huang <hl at rock-chips.com>
Gerrit-Reviewer: Matthias Kaehlcke <mka at chromium.org>
Gerrit-Reviewer: Philip Chen <philipchen at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 02 Feb 2018 06:32:08 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180202/2377ded5/attachment.html>