[coreboot-gerrit] Change in coreboot[master]: google/scarlet: Innolux P097PFG panel use new version initial code

[Matthias Kaehlcke (Code Review)]

Matthias Kaehlcke has posted comments on this change. ( https://review.coreboot.org/23561 )

Change subject: google/scarlet: Innolux P097PFG panel use new version initial code
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

Verified to be working on dru.

Matches the kernel sequence from https://crosreview.com/890565

LGTM besides the comments on the commit message.

https://review.coreboot.org/#/c/23561/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/23561/1//COMMIT_MSG@7
PS1, Line 7: google/scarlet: Innolux P097PFG panel use new version initial code
           : 
           : There is artifact line in the lower third of the display with now
           : initial code. So update this initial code to fix this issue.
You could also mention that this is a sequence provided by Innolux, as opposed to the register dump hack that we merged initially.


https://review.coreboot.org/#/c/23561/1//COMMIT_MSG@12
PS1, Line 12: BUG=b:69689064, b:72191820
            : BRANCH=gru
            : TEST=boot on dru with an Innolux panel and artifact line disappear.
I'm not really familiar with coreboot upstream work, but I suppose these Chrome OS specific tags are meaningless here.



-- 
To view, visit https://review.coreboot.org/23561
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9679c4f7f706fd6cd2e1dba7ec79e772fe3f227a
Gerrit-Change-Number: 23561
Gerrit-PatchSet: 1
Gerrit-Owner: Lin Huang <hl at rock-chips.com>
Gerrit-Reviewer: Brian Norris <briannorris at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Matthias Kaehlcke <mka at chromium.org>
Gerrit-Reviewer: Philip Chen <philipchen at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 02 Feb 2018 02:55:32 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180202/7c237bea/attachment.html>