[coreboot-gerrit] Change in coreboot[master]: google/kahlee: Initialize non-early i2c buses in mainboard_init
Daniel Kurtz (Code Review)
gerrit at coreboot.org
Thu Feb 1 23:59:11 CET 2018
Hello Daniel Kurtz,
I'd like you to do a code review. Please visit
https://review.coreboot.org/23554
to review the following change.
Change subject: google/kahlee: Initialize non-early i2c buses in mainboard_init
......................................................................
google/kahlee: Initialize non-early i2c buses in mainboard_init
Initialize non-early i2c buses in ramstage.
BUG=b:69407112
TEST=Boot depthcharge w/ CLI enabled on grunt.
devbeep
=> plays beep
BRANCH=None
Change-Id: I634a7a823cc393243841dbd55e52abe3f0e72c5a
Signed-off-by: Daniel Kurtz <djkurtz at chromium.org>
---
M src/mainboard/google/kahlee/mainboard.c
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/23554/1
diff --git a/src/mainboard/google/kahlee/mainboard.c b/src/mainboard/google/kahlee/mainboard.c
index b080682..b1a449d 100644
--- a/src/mainboard/google/kahlee/mainboard.c
+++ b/src/mainboard/google/kahlee/mainboard.c
@@ -138,6 +138,9 @@
gpes = get_gpe_table(&num);
gpe_configure_sci(gpes, num);
+ /* Initialize i2c busses that were not initialized in bootblock */
+ i2c_soc_init();
+
/* Set GenIntDisable so that GPIO 90 is configured as a GPIO. */
if (!IS_ENABLED(CONFIG_BOARD_GOOGLE_KAHLEE))
pm_write8(PM_PCIB_CFG,
--
To view, visit https://review.coreboot.org/23554
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I634a7a823cc393243841dbd55e52abe3f0e72c5a
Gerrit-Change-Number: 23554
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180201/9938991f/attachment-0001.html>
More information about the coreboot-gerrit
mailing list