[coreboot-gerrit] Change in coreboot[master]: mb/google/kahlee: Enable wlan card so it can be detected

Martin Roth (Code Review) gerrit at coreboot.org
Thu Feb 1 23:17:22 CET 2018


Martin Roth has uploaded this change for review. ( https://review.coreboot.org/23552


Change subject: mb/google/kahlee: Enable wlan card so it can be detected
......................................................................

mb/google/kahlee: Enable wlan card so it can be detected

The wifi card was not being powered, and was being held in reset during
PCI enumeration, so it was not being brought up.

BUG=b:72738963
TEST=Verify wlan card shows up in lspci

Change-Id: I5a1e83298af35aa80c67c75cd6ec0a2c3213891e
Signed-off-by: Martin Roth <martinroth at google.com>
---
M src/mainboard/google/kahlee/variants/baseboard/gpio.c
1 file changed, 6 insertions(+), 6 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/23552/1

diff --git a/src/mainboard/google/kahlee/variants/baseboard/gpio.c b/src/mainboard/google/kahlee/variants/baseboard/gpio.c
index 6954f63..a6bcea5 100644
--- a/src/mainboard/google/kahlee/variants/baseboard/gpio.c
+++ b/src/mainboard/google/kahlee/variants/baseboard/gpio.c
@@ -38,6 +38,9 @@
 	/* GPIO_3 - MEM_VOLT_SEL */
 	{ GPIO_3, Function0, FCH_GPIO_PULL_UP_ENABLE | INPUT },
 
+	/* GPIO_4 - EN_PP3300_WLAN */
+	{ GPIO_4, Function0, OUTPUT_H },
+
 	/* GPIO_5 - PCH_TRACKPAD_INT_3V3_ODL, SCI */
 	{ GPIO_5, Function0, FCH_GPIO_PULL_UP_ENABLE | INPUT },
 
@@ -90,6 +93,9 @@
 	/* GPIO_42 - S5_MUX_CTRL */
 	{ GPIO_42, Function0, OUTPUT_H },
 
+	/* GPIO_70 - WLAN_PE_RST_L */
+	{ GPIO_70, Function0, OUTPUT_H },
+
 	/* GPIO_74 - LPC_CLK0_EC_R */
 	{ GPIO_74, Function0, FCH_GPIO_PULL_DOWN_ENABLE | INPUT },
 
@@ -197,9 +203,6 @@
 	/* GPIO_2 - WLAN_PCIE_WAKE_3V3_ODL */
 	{ GPIO_2, Function0, FCH_GPIO_PULL_UP_ENABLE | INPUT },
 
-	/* GPIO_4 - EN_PP3300_WLAN */
-	{ GPIO_4, Function0, OUTPUT_H },
-
 	/* GPIO_10 - SLP_S0_L (currently not used) */
 	{ GPIO_10, Function0, FCH_GPIO_PULL_UP_ENABLE | INPUT },
 
@@ -221,9 +224,6 @@
 	/* GPIO_67 - PEN_RESET */
 	{ GPIO_67, Function0, OUTPUT_L },
 
-	/* GPIO_70 - WLAN_PE_RST_L */
-	{ GPIO_70, Function0, OUTPUT_H },
-
 	/* GPIO_75 - Unused (strap) (R139/R130) */
 	{ GPIO_75, Function1, FCH_GPIO_PULL_UP_ENABLE | INPUT },
 

-- 
To view, visit https://review.coreboot.org/23552
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5a1e83298af35aa80c67c75cd6ec0a2c3213891e
Gerrit-Change-Number: 23552
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180201/71c13281/attachment-0001.html>


More information about the coreboot-gerrit mailing list