[coreboot-gerrit] Change in coreboot[master]: mainboard/msi/ms9282: Fix coding style

Elyes HAOUAS (Code Review) gerrit at coreboot.org
Thu Feb 1 09:28:05 CET 2018


Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/23535


Change subject: mainboard/msi/ms9282: Fix coding style
......................................................................

mainboard/msi/ms9282: Fix coding style

Change-Id: I6fb31238afff56ff16cf58104f8bed8e9832544c
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
M src/mainboard/msi/ms9282/mptable.c
1 file changed, 6 insertions(+), 7 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/23535/1

diff --git a/src/mainboard/msi/ms9282/mptable.c b/src/mainboard/msi/ms9282/mptable.c
index 4619737..c53fe78 100644
--- a/src/mainboard/msi/ms9282/mptable.c
+++ b/src/mainboard/msi/ms9282/mptable.c
@@ -99,17 +99,16 @@
 //NIC2
 	smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, m->bus_mcp55[0], ((sbdn+9)<<2)|0, m->apicid_mcp55, 0x15); // 21
 
-	for(j = 7; j >= 2; j--) {
-		if(!m->bus_mcp55[j]) continue;
-		for(i = 0; i < 4; i++) {
+	for (j = 7; j >= 2; j--) {
+		if (!m->bus_mcp55[j])
+			continue;
+		for (i = 0; i < 4; i++)
 			smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, m->bus_mcp55[j], (0x00 << 2)|i, m->apicid_mcp55, 0x10 + (2+j+i+4-sbdn%4)%4);
-		}
 	}
 
-	for(j = 0; j < 1; j++)
-		for(i = 0; i < 4; i++) {
+	for (j = 0; j < 1; j++)
+		for (i = 0; i < 4; i++)
 			smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, m->bus_mcp55[1], ((0x04+j)<<2)|i, m->apicid_mcp55, 0x10 + (2+i+j)%4);
-		}
 
 /*Local Ints:  Type    Polarity    Trigger     Bus ID   IRQ    APIC ID PIN#*/
 	mptable_lintsrc(mc, bus_isa);

-- 
To view, visit https://review.coreboot.org/23535
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6fb31238afff56ff16cf58104f8bed8e9832544c
Gerrit-Change-Number: 23535
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180201/4bb21277/attachment.html>


More information about the coreboot-gerrit mailing list