[coreboot-gerrit] Change in ...coreboot[master]: mainboard/facebook/fbg1701: Do initial mainboard commit

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30414 )

Change subject: mainboard/facebook/fbg1701: Do initial mainboard commit
......................................................................


Patch Set 3:

(2 comments)

https://review.coreboot.org/#/c/30414/3/src/mainboard/facebook/fbg1701/irqroute.h 
File src/mainboard/facebook/fbg1701/irqroute.h:

https://review.coreboot.org/#/c/30414/3/src/mainboard/facebook/fbg1701/irqroute.h@40 
PS3, Line 40: #define PCI_DEV_PIRQ_ROUTES \
Macros with complex values should be enclosed in parentheses


https://review.coreboot.org/#/c/30414/3/src/mainboard/facebook/fbg1701/irqroute.h@62 
PS3, Line 62: #define PIRQ_PIC_ROUTES \
Macros with complex values should be enclosed in parentheses



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30414
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28ac78a630ee705b1e546031f024bfe7f952ab39
Gerrit-Change-Number: 30414
Gerrit-PatchSet: 3
Gerrit-Owner: Frans Hendriks <fhendriks at eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks at eltan.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 24 Dec 2018 12:54:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181224/7b6f26e0/attachment.html>