[coreboot-gerrit] Change in ...coreboot[master]: mainboard/facebook/fbg1701: Do initial mainboard commit

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30414 )

Change subject: mainboard/facebook/fbg1701: Do initial mainboard commit
......................................................................


Patch Set 2:

(7 comments)

https://review.coreboot.org/#/c/30414/2/src/mainboard/facebook/fbg1701/irqroute.h 
File src/mainboard/facebook/fbg1701/irqroute.h:

https://review.coreboot.org/#/c/30414/2/src/mainboard/facebook/fbg1701/irqroute.h@40 
PS2, Line 40: #define PCI_DEV_PIRQ_ROUTES \
Macros with complex values should be enclosed in parentheses


https://review.coreboot.org/#/c/30414/2/src/mainboard/facebook/fbg1701/irqroute.h@62 
PS2, Line 62: #define PIRQ_PIC_ROUTES \
Macros with complex values should be enclosed in parentheses


https://review.coreboot.org/#/c/30414/2/src/soc/intel/braswell/smbus.c 
File src/soc/intel/braswell/smbus.c:

https://review.coreboot.org/#/c/30414/2/src/soc/intel/braswell/smbus.c@69 
PS2, Line 69: 		if ((val & SMBHSTSTS_HOST_BUSY)) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/30414/2/src/soc/intel/braswell/smbus.c@135 
PS2, Line 135: 	for (bytes_write=0; bytes_write < bytes; bytes_write++) {
spaces required around that '=' (ctx:VxV)


https://review.coreboot.org/#/c/30414/2/src/soc/intel/braswell/smbus.c@156 
PS2, Line 156: 			if (bytes_write+1 < bytes) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/30414/2/src/soc/intel/braswell/smbus.c@169 
PS2, Line 169: 		else
else should follow close brace '}'


https://review.coreboot.org/#/c/30414/2/src/soc/intel/braswell/smbus.c@263 
PS2, Line 263: 		else
else should follow close brace '}'



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30414
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28ac78a630ee705b1e546031f024bfe7f952ab39
Gerrit-Change-Number: 30414
Gerrit-PatchSet: 2
Gerrit-Owner: Frans Hendriks <fhendriks at eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks at eltan.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 24 Dec 2018 11:31:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181224/c6635c19/attachment.html>