[coreboot-gerrit] Change in ...coreboot[master]: drivers/aspeed/ast: Select `MAINBOARD_HAS_NATIVE_VGA_INIT`

Patrick Georgi (Code Review) gerrit at coreboot.org
Mon Dec 24 09:15:50 CET 2018


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30355 )

Change subject: drivers/aspeed/ast: Select `MAINBOARD_HAS_NATIVE_VGA_INIT`
......................................................................

drivers/aspeed/ast: Select `MAINBOARD_HAS_NATIVE_VGA_INIT`

Any board that uses the AST driver will have support for native graphics
init. So, select the option in the driver instead of every board.

Change-Id: I2bf42c168d1ffdda11857854889b74953abd7e40
Signed-off-by: Tristan Corrick <tristan at corrick.kiwi>
Reviewed-on: https://review.coreboot.org/c/30355
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: HAOUAS Elyes <ehaouas at noos.fr>
Reviewed-by: Nico Huber <nico.h at gmx.de>
---
M src/drivers/aspeed/ast2050/Kconfig
M src/mainboard/asus/kcma-d8/Kconfig
M src/mainboard/asus/kgpe-d16/Kconfig
3 files changed, 1 insertion(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved
  HAOUAS Elyes: Looks good to me, but someone else must approve



diff --git a/src/drivers/aspeed/ast2050/Kconfig b/src/drivers/aspeed/ast2050/Kconfig
index 715def8..337b181 100644
--- a/src/drivers/aspeed/ast2050/Kconfig
+++ b/src/drivers/aspeed/ast2050/Kconfig
@@ -2,3 +2,4 @@
 	bool
 	select DRIVERS_ASPEED_AST_COMMON
 	select HAVE_VGA_TEXT_FRAMEBUFFER
+	select MAINBOARD_HAS_NATIVE_VGA_INIT
diff --git a/src/mainboard/asus/kcma-d8/Kconfig b/src/mainboard/asus/kcma-d8/Kconfig
index 229b5ac..7d66707 100644
--- a/src/mainboard/asus/kcma-d8/Kconfig
+++ b/src/mainboard/asus/kcma-d8/Kconfig
@@ -31,7 +31,6 @@
 	select DRIVERS_I2C_W83795
 	select DRIVERS_ASPEED_AST2050
 	select MAINBOARD_FORCE_NATIVE_VGA_INIT
-	select MAINBOARD_HAS_NATIVE_VGA_INIT
 
 config MAINBOARD_DIR
 	string
diff --git a/src/mainboard/asus/kgpe-d16/Kconfig b/src/mainboard/asus/kgpe-d16/Kconfig
index d87d926..efdade8 100644
--- a/src/mainboard/asus/kgpe-d16/Kconfig
+++ b/src/mainboard/asus/kgpe-d16/Kconfig
@@ -32,7 +32,6 @@
 	select DRIVERS_I2C_W83795
 	select DRIVERS_ASPEED_AST2050
 	select MAINBOARD_FORCE_NATIVE_VGA_INIT
-	select MAINBOARD_HAS_NATIVE_VGA_INIT
 
 config MAINBOARD_DIR
 	string

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30355
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2bf42c168d1ffdda11857854889b74953abd7e40
Gerrit-Change-Number: 30355
Gerrit-PatchSet: 2
Gerrit-Owner: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Timothy Pearson <tpearson at raptorengineering.com>
Gerrit-Reviewer: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181224/46b79462/attachment.html>


More information about the coreboot-gerrit mailing list