[coreboot-gerrit] Change in ...coreboot[master]: nb/intel/haswell: Handle boards that do not support IGD

Tristan Corrick (Code Review) gerrit at coreboot.org
Mon Dec 24 06:49:06 CET 2018


Hello Patrick Rudolph, Angel Pons, Arthur Heymans, build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/30271

to look at the new patch set (#4).

Change subject: nb/intel/haswell: Handle boards that do not support IGD
......................................................................

nb/intel/haswell: Handle boards that do not support IGD

Processor graphics is disabled on, for example, the C222 and C224
chipsets.

The change to resource assignment in northbridge.c prevents the following
warning that occurs when the IGD is disabled:

> skipping PCI: 00:00.0 at 3 fixed resource, size=0!

Tested on a Supermicro X10SLM+-F, which has the IGD disabled by the
chipset. The graphics memory is reclaimed and no issues were observed.

Also tested on an ASRock H81M-HDS. This board has an IGD, but no
regressions were observed.

Change-Id: I86d4aef50b6588f08b86c9758a4b95ccd65e9a96
Signed-off-by: Tristan Corrick <tristan at corrick.kiwi>
---
M src/northbridge/intel/haswell/early_init.c
M src/northbridge/intel/haswell/haswell.h
M src/northbridge/intel/haswell/northbridge.c
3 files changed, 41 insertions(+), 19 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/30271/4
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30271
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I86d4aef50b6588f08b86c9758a4b95ccd65e9a96
Gerrit-Change-Number: 30271
Gerrit-PatchSet: 4
Gerrit-Owner: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181224/21f703ef/attachment.html>


More information about the coreboot-gerrit mailing list