[coreboot-gerrit] Change in ...coreboot[master]: mb/google/hatch: Add HPD GPIO support for displays

[Maulik V Vaghela (Code Review)]

Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30365 )

Change subject: mb/google/hatch: Add HPD GPIO support for displays
......................................................................


Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/30365/2/src/mainboard/google/hatch/variants/baseboard/gpio.c 
File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/30365/2/src/mainboard/google/hatch/variants/baseboard/gpio.c@36 
PS2, Line 36: /* USB_C0_DP_HPD */
            : 	PAD_CFG_NF(GPP_E13, NONE, DEEP, NF1),
            : 	/* DDI2_HPD_OPL */
            : 	PAD_CFG_NF(GPP_E14, NONE, DEEP, NF1),
            : 	/* EDP_HPD */
            : 	PAD_CFG_NF(GPP_E17, NONE, DEEP, NF1),
> can you please make the comments consistent with above?
Done



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30365
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If9d52dc0f9916f761c8fdd88c76968aaf663e650
Gerrit-Change-Number: 30365
Gerrit-PatchSet: 3
Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela at intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 24 Dec 2018 03:53:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181224/811bc90d/attachment.html>