[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/broadwell: Clean up unused functions

Arthur Heymans (Code Review) gerrit at coreboot.org
Sat Dec 22 17:04:11 CET 2018


Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30382


Change subject: soc/intel/broadwell: Clean up unused functions
......................................................................

soc/intel/broadwell: Clean up unused functions

Since 90cca54 "soc/intel/broadwell: Implement postcar stage" those
functions are unused.

Change-Id: I023019a06a7344a5b646cbf921210f9101408f57
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/soc/intel/broadwell/include/soc/romstage.h
M src/soc/intel/broadwell/romstage/romstage.c
2 files changed, 0 insertions(+), 10 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/30382/1

diff --git a/src/soc/intel/broadwell/include/soc/romstage.h b/src/soc/intel/broadwell/include/soc/romstage.h
index e52004b..17d711f 100644
--- a/src/soc/intel/broadwell/include/soc/romstage.h
+++ b/src/soc/intel/broadwell/include/soc/romstage.h
@@ -31,9 +31,7 @@
 void romstage_common(struct romstage_params *params);
 asmlinkage void *romstage_main(unsigned long bist, uint32_t tsc_lo,
 			       uint32_t tsc_high);
-asmlinkage void romstage_after_car(void);
 void raminit(struct pei_data *pei_data);
-void *setup_stack_and_mtrrs(void);
 
 struct chipset_power_state;
 struct chipset_power_state *fill_power_state(void);
diff --git a/src/soc/intel/broadwell/romstage/romstage.c b/src/soc/intel/broadwell/romstage/romstage.c
index 1e92521..afc8216 100644
--- a/src/soc/intel/broadwell/romstage/romstage.c
+++ b/src/soc/intel/broadwell/romstage/romstage.c
@@ -139,12 +139,4 @@
 	romstage_handoff_init(params->power_state->prev_sleep_state == ACPI_S3);
 }
 
-asmlinkage void romstage_after_car(void)
-{
-	/* Load the ramstage. */
-	run_ramstage();
-	while (1)
-		;
-}
-
 void __weak mainboard_pre_console_init(void) {}

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30382
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I023019a06a7344a5b646cbf921210f9101408f57
Gerrit-Change-Number: 30382
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181222/8c397f26/attachment-0001.html>


More information about the coreboot-gerrit mailing list