[coreboot-gerrit] Change in ...coreboot[master]: mb/google/poppy/variants/nami: Add micron_dimm_MT40A512M16TB-062EJ SPD

Patrick Georgi (Code Review) gerrit at coreboot.org
Fri Dec 21 19:15:19 CET 2018


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30327 )

Change subject: mb/google/poppy/variants/nami: Add micron_dimm_MT40A512M16TB-062EJ SPD
......................................................................

mb/google/poppy/variants/nami: Add micron_dimm_MT40A512M16TB-062EJ SPD

Add SPD file for micron_dimm_MT40A512M16TB-062EJ (ram id: 12)

BUG=b:121217853
BRANCH=firmware-nami-10775.B
TEST=emerge-nami coreboot chromeos-bootimage

Change-Id: I45e6a7a183556fb085f5442cd6bb429d79ef4235
Signed-off-by: Frank Wu <frank_wu at compal.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/30327
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Furquan Shaikh <furquan at google.com>
---
A src/mainboard/google/poppy/spd/micron_dimm_MT40A512M16TB-062EJ.spd.hex
M src/mainboard/google/poppy/variants/nami/Makefile.inc
2 files changed, 33 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved



diff --git a/src/mainboard/google/poppy/spd/micron_dimm_MT40A512M16TB-062EJ.spd.hex b/src/mainboard/google/poppy/spd/micron_dimm_MT40A512M16TB-062EJ.spd.hex
new file mode 100644
index 0000000..4c44041
--- /dev/null
+++ b/src/mainboard/google/poppy/spd/micron_dimm_MT40A512M16TB-062EJ.spd.hex
@@ -0,0 +1,32 @@
+23 11 0C 03 45 21 00 08 00 60 00 03 02 03 00 00
+00 00 05 0D F8 FF 2B 00 6E 6E 6E 11 00 6E F0 0A
+20 08 00 05 00 F0 2B 34 28 00 78 00 14 3C 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 9C B5 00 00 00 00 E7 00 D0 19
+0F 01 02 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 C0 E2
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+80 2C 00 00 00 00 00 00 00 34 41 54 46 35 31 32
+36 34 48 5A 2D 33 47 32 4A 31 20 20 20 31 80 2C
+4A 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
diff --git a/src/mainboard/google/poppy/variants/nami/Makefile.inc b/src/mainboard/google/poppy/variants/nami/Makefile.inc
index 53c7cd1..7f86bb7 100644
--- a/src/mainboard/google/poppy/variants/nami/Makefile.inc
+++ b/src/mainboard/google/poppy/variants/nami/Makefile.inc
@@ -13,7 +13,7 @@
 SPD_SOURCES += samsung_dimm_K4AAG165WB-MCRC	# 0b1001
 SPD_SOURCES += hynix_dimm_H5AN4G6NAFR-UHC	# 0b1010
 SPD_SOURCES += micron_dimm_MT40A256M16LY-075F	# 0b1011
-SPD_SOURCES += empty_ddr4			# 0b1100
+SPD_SOURCES += micron_dimm_MT40A512M16TB-062EJ	# 0b1100
 SPD_SOURCES += micron_dimm_MT40A1G16KNR-075E	# 0b1101
 SPD_SOURCES += micron_dimm_MT40A512M16LY-075E	# 0b1110
 SPD_SOURCES += hynix_dimm_H5AN8G6NCJR-VKC	# 0b1111

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30327
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45e6a7a183556fb085f5442cd6bb429d79ef4235
Gerrit-Change-Number: 30327
Gerrit-PatchSet: 3
Gerrit-Owner: Frank Wu <frank_wu at compal.corp-partner.google.com>
Gerrit-Reviewer: Frank Wu <frank_wu at compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Chris Zhou <chris_zhou at compal.corp-partner.google.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181221/b6be6d6b/attachment.html>


More information about the coreboot-gerrit mailing list