[coreboot-gerrit] Change in ...coreboot[master]: util/release: Don't assume the source is in a directory called coreboot
Patrick Georgi (Code Review)
gerrit at coreboot.org
Fri Dec 21 19:06:40 CET 2018
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30343 )
Change subject: util/release: Don't assume the source is in a directory called coreboot
......................................................................
util/release: Don't assume the source is in a directory called coreboot
Change-Id: I384ff2f01b38916851522411d0c25c49793fe480
Signed-off-by: Patrick Georgi <pgeorgi at google.com>
Reviewed-on: https://review.coreboot.org/c/30343
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Martin Roth <martinroth at google.com>
Reviewed-by: Angel Pons <th3fanbus at gmail.com>
---
M util/release/genrelnotes
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
build bot (Jenkins): Verified
Martin Roth: Looks good to me, approved
Angel Pons: Looks good to me, but someone else must approve
diff --git a/util/release/genrelnotes b/util/release/genrelnotes
index 6d5aa52..9a88b49 100755
--- a/util/release/genrelnotes
+++ b/util/release/genrelnotes
@@ -410,7 +410,7 @@
for module in $(git submodule --quiet foreach pwd); do
name=$(basename "$module")
# shellcheck disable=SC2001
- path=$(echo "$module" | sed 's|.*coreboot||')
+ path=${module#$PWD}
old_version=$(echo "${name^^}_OLD_VERSION" | sed 's/-/_/g')
new_version=$(echo "${name^^}_NEW_VERSION" | sed 's/-/_/g')
get_log_submodule "${!old_version}" "${!new_version}" "$path"
--
To view, visit https://review.coreboot.org/c/coreboot/+/30343
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I384ff2f01b38916851522411d0c25c49793fe480
Gerrit-Change-Number: 30343
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181221/42f28c05/attachment.html>
More information about the coreboot-gerrit
mailing list