[coreboot-gerrit] Change in ...coreboot[master]: drivers/generic/bayhub: Add reset capability

[Richard Spiegel (Code Review)]

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30319 )

Change subject: drivers/generic/bayhub: Add reset capability
......................................................................


Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/30319/2/src/drivers/generic/bayhub/bh720.c 
File src/drivers/generic/bayhub/bh720.c:

https://review.coreboot.org/#/c/30319/2/src/drivers/generic/bayhub/bh720.c@91 
PS2, Line 91: static const unsigned short pci_device_ids[] = {
> Hmmm, that's really little. I'm confused. […]
Depthcharge is actually fast, it's just a secure loader. What takes time is the actual loading of the OS. But obviously, once the OS starts loading, eMMC is already working. Depthcharge is loaded from the flash, selects where to load from, checks some security (not sure which, but would assume TPM related). and loads the OS (normally chrome OS).



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30319
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic3878ee782c8da1a28c6d669dd7eceda7c8cf4e5
Gerrit-Change-Number: 30319
Gerrit-PatchSet: 3
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Simon Glass <sjg at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 21 Dec 2018 14:15:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Richard Spiegel <richard.spiegel at silverbackltd.com>
Comment-In-Reply-To: Nico Huber <nico.h at gmx.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181221/c0732393/attachment.html>