[coreboot-gerrit] Change in ...coreboot[master]: {devices, lib, security} Add Eltan vendor code for measured and verifie...

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Fri Dec 21 12:40:01 CET 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30218 )

Change subject: {devices,lib,security} Add Eltan vendor code for measured and verified boot.
......................................................................


Patch Set 5:

(2 comments)

https://review.coreboot.org/#/c/30218/5/src/security/tpm/tss.h 
File src/security/tpm/tss.h:

https://review.coreboot.org/#/c/30218/5/src/security/tpm/tss.h@131 
PS5, Line 131: 			    uint32_t PropertyCount, TPMI_YES_NO *MoreData,
need consistent spacing around '*' (ctx:WxV)


https://review.coreboot.org/#/c/30218/5/src/security/tpm/tss.h@132 
PS5, Line 132: 			    TPMS_CAPABILITY_DATA *CapabilityData);
need consistent spacing around '*' (ctx:WxV)



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30218
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic1d5a21d40b6a31886777e8e9fe7b28c860f1a80
Gerrit-Change-Number: 30218
Gerrit-PatchSet: 5
Gerrit-Owner: Frans Hendriks <fhendriks at eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks at eltan.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
Gerrit-Comment-Date: Fri, 21 Dec 2018 11:40:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181221/8ff487b7/attachment.html>


More information about the coreboot-gerrit mailing list