[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/fsp_broadwell_de/acpi: Fix wrong table checksum

[Patrick Rudolph (Code Review)]

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30353


Change subject: soc/intel/fsp_broadwell_de/acpi: Fix wrong table checksum
......................................................................

soc/intel/fsp_broadwell_de/acpi: Fix wrong table checksum

Fix the following warning shown in dmesg:
"ACPI BIOS Warning (bug): Incorrect checksum in table [FACP]"

The table checksum was wrong as it was calculated twice and with the second
time the checksum field wasn't set to zero.

Change-Id: I375354bf3e95ebdac3b0dad43659d72c6ab3175a
Signed-off-by: Patrick Rudolph <patrick.rudolph at 9elements.com>
---
M src/soc/intel/fsp_broadwell_de/acpi.c
1 file changed, 0 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/30353/1

diff --git a/src/soc/intel/fsp_broadwell_de/acpi.c b/src/soc/intel/fsp_broadwell_de/acpi.c
index 15ea5ec..728850d 100644
--- a/src/soc/intel/fsp_broadwell_de/acpi.c
+++ b/src/soc/intel/fsp_broadwell_de/acpi.c
@@ -309,8 +309,6 @@
 	fadt->x_gpe1_blk.access_size     = 0;
 	fadt->x_gpe1_blk.addrl           = fadt->gpe1_blk;
 	fadt->x_gpe1_blk.addrh           = 0x00;
-
-	header->checksum = acpi_checksum((void *) fadt, sizeof(acpi_fadt_t));
 }
 
 static unsigned long acpi_fill_dmar(unsigned long current)

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30353
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I375354bf3e95ebdac3b0dad43659d72c6ab3175a
Gerrit-Change-Number: 30353
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181221/49a2dc85/attachment.html>