[coreboot-gerrit] Change in ...coreboot[master]: mb/google/hatch: Fixes to initial hatch mainboard checkin

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30296 )

Change subject: mb/google/hatch: Fixes to initial hatch mainboard checkin
......................................................................


Patch Set 8:

(1 comment)

https://review.coreboot.org/#/c/30296/8/src/mainboard/google/hatch/variants/baseboard/gpio.c 
File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/30296/8/src/mainboard/google/hatch/variants/baseboard/gpio.c@30 
PS8, Line 30: /* H1_PCH_INT_ODL */
            : 	PAD_CFG_GPI_APIC(GPP_C21, NONE, DEEP, LEVEL, INVERT),
            : 	/* PCH_WP_OD */
            : 	PAD_CFG_GPI(GPP_C20, NONE, DEEP),
            : 	/* EC_IN_RW_OD */
            : 	PAD_CFG_GPI(GPP_C22, NONE, DEEP),
            : };
order?



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30296
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e311c68873f10f71314e44d3a714639a06dbee8
Gerrit-Change-Number: 30296
Gerrit-PatchSet: 8
Gerrit-Owner: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 21 Dec 2018 09:51:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181221/e295c46c/attachment.html>