[coreboot-gerrit] Change in ...coreboot[master]: mb/google/hatch: Fixes to initial hatch mainboard checkin

[V Sowmya (Code Review)]

V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30296 )

Change subject: mb/google/hatch: Fixes to initial hatch mainboard checkin
......................................................................


Patch Set 8:

(3 comments)

https://review.coreboot.org/#/c/30296/6/src/mainboard/google/hatch/Kconfig 
File src/mainboard/google/hatch/Kconfig:

https://review.coreboot.org/#/c/30296/6/src/mainboard/google/hatch/Kconfig@a5 
PS6, Line 5: 
           : 
           : 
> Need it now for Trackpad and TPM
Done


https://review.coreboot.org/#/c/30296/7/src/mainboard/google/hatch/chromeos.fmd 
File src/mainboard/google/hatch/chromeos.fmd:

https://review.coreboot.org/#/c/30296/7/src/mainboard/google/hatch/chromeos.fmd@a32 
PS7, Line 32: 
> please adjust the subsequent sections' base and size so as to not leave any unmapped areas
Done


https://review.coreboot.org/#/c/30296/7/src/mainboard/google/hatch/chromeos.fmd@4 
PS7, Line 4: SI_ME
> u can safely say to avoid having unused section there […]
I have set SI_ALL=3MB and aligned the base and sizes.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30296
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e311c68873f10f71314e44d3a714639a06dbee8
Gerrit-Change-Number: 30296
Gerrit-PatchSet: 8
Gerrit-Owner: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 21 Dec 2018 09:13:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subrata.banik at intel.com>
Comment-In-Reply-To: Aamir Bohra <aamir.bohra at intel.com>
Comment-In-Reply-To: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181221/6885edc8/attachment.html>