[coreboot-gerrit] Change in ...coreboot[master]: mb/google/hatch: Add EC trigger events and acpi configs

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30281 )

Change subject: mb/google/hatch: Add EC trigger events and acpi configs
......................................................................


Patch Set 11:

(1 comment)

https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h 
File src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h:

https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h@79 
PS7, Line 79: * __BASEBOARD_EC_H
> aamir have u added this line to enable PS2 keyboard like DE? […]
Yes, I think this can be part of this CL since we are enabling ACPI configs for other EC ACPI devices(ALS, PD device) also here, I'll update the commit message to highlight the same. Thoughts?



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30281
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a86f609c269cb59e546fc7ba4ba032e5ea8341a
Gerrit-Change-Number: 30281
Gerrit-PatchSet: 11
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 21 Dec 2018 08:15:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subrata.banik at intel.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181221/5dbe0e87/attachment.html>