[coreboot-gerrit] Change in ...coreboot[master]: util/xcompile/xcompile: Enable x86_64 support

Patrick Georgi (Code Review) gerrit at coreboot.org
Thu Dec 20 23:13:50 CET 2018


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/29877 )

Change subject: util/xcompile/xcompile: Enable x86_64 support
......................................................................

util/xcompile/xcompile: Enable x86_64 support

Similar to i686 on x86_32, compile for nocona on x86_64.
Nocona is the first Pentium 4 CPU that has long mode support.
Required for 64bit support.

Change-Id: Ied28f98f89610a748be8d66cf35814e9112a4407
Signed-off-by: Patrick Rudolph <siro at das-labor.org>
Reviewed-on: https://review.coreboot.org/c/29877
Reviewed-by: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
---
M util/xcompile/xcompile
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Philipp Deppenwiese: Looks good to me, approved



diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile
index d416e5d..58f60f0 100755
--- a/util/xcompile/xcompile
+++ b/util/xcompile/xcompile
@@ -236,7 +236,13 @@
 # The Quark processor doesn't support the instructions
 # introduced with the Pentium 6 architecture, so allow it
 # to use i586 instead.
-if [ "${TARCH}" = "x86_64" ] || [ "${TARCH}" = "x86_32" ]; then
+if [ "${TARCH}" = "x86_64" ]; then
+cat <<EOF
+        GCC_CFLAGS_${TARCH} += -march=nocona
+EOF
+fi
+
+if [ "${TARCH}" = "x86_32" ]; then
 cat <<EOF
 
 ifneq (\$(CONFIG_USE_MARCH_586)\$(CONFIG_LP_USE_MARCH_586),)

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29877
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ied28f98f89610a748be8d66cf35814e9112a4407
Gerrit-Change-Number: 29877
Gerrit-PatchSet: 8
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181220/2882c0e1/attachment.html>


More information about the coreboot-gerrit mailing list