[coreboot-gerrit] Change in ...coreboot[master]: drivers/generic/bayhub: Add reset capability

Richard Spiegel (Code Review) gerrit at coreboot.org
Thu Dec 20 19:37:54 CET 2018


Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30319 )

Change subject: drivers/generic/bayhub: Add reset capability
......................................................................


Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/30319/2/src/drivers/generic/bayhub/bh720.c 
File src/drivers/generic/bayhub/bh720.c:

https://review.coreboot.org/#/c/30319/2/src/drivers/generic/bayhub/bh720.c@91 
PS2, Line 91: static const unsigned short pci_device_ids[] = {
> I know. I would have preferred romstage. […]
You were correct. Saved time barely 5 milliseconds. I'll try an experiment with code at romstage.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30319
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic3878ee782c8da1a28c6d669dd7eceda7c8cf4e5
Gerrit-Change-Number: 30319
Gerrit-PatchSet: 3
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Simon Glass <sjg at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 20 Dec 2018 18:37:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Richard Spiegel <richard.spiegel at silverbackltd.com>
Comment-In-Reply-To: Nico Huber <nico.h at gmx.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181220/f86ea3f9/attachment.html>


More information about the coreboot-gerrit mailing list